From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Thu, 20 Dec 2012 03:46:50 +0000 (-0500)
Subject: volume: Pick up hasHeadphones from the signal handler
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5166
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=1a4948f0f2ef0c3c17f3b116fdf5bdaa9268741b;p=gnome-shell.git

volume: Pick up hasHeadphones from the signal handler

A preliminary patch for big cleanups happening soon.

https://bugzilla.gnome.org/show_bug.cgi?id=690539
---

diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js
index 859b403ca..b1774fc88 100644
--- a/js/ui/status/volume.js
+++ b/js/ui/status/volume.js
@@ -33,7 +33,7 @@ const VolumeMenu = new Lang.Class({
     _init: function(control) {
         this.parent();
 
-        this.hasHeadphones = false;
+        this._hasHeadphones = false;
 
         this._control = control;
         this._control.connect('state-changed', Lang.bind(this, this._onControlStateChanged));
@@ -100,8 +100,8 @@ const VolumeMenu = new Lang.Class({
     },
 
     _portChanged: function() {
-        this.hasHeadphones = this._findHeadphones(this._output);
-        this.emit('headphones-changed');
+        this._hasHeadphones = this._findHeadphones(this._output);
+        this.emit('headphones-changed', this._hasHeadphones);
     },
 
     _readOutput: function() {
@@ -231,8 +231,8 @@ const Indicator = new Lang.Class({
             this.actor.visible = (icon != null);
             this.setIcon(icon);
         }));
-        this._volumeMenu.connect('headphones-changed', Lang.bind(this, function() {
-            this._headphoneIcon.visible = this._volumeMenu.hasHeadphones;
+        this._volumeMenu.connect('headphones-changed', Lang.bind(this, function(menu, value) {
+            this._headphoneIcon.visible = value;
         }));
 
         this._headphoneIcon = this.addIcon(new Gio.ThemedIcon({ name: 'headphones-symbolic' }));